Correct rounding of synaptic delays in the cortical microcircuit examples #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhnnsnk
reviewed
Oct 31, 2022
There was a problem hiding this comment.
Well spotted! I think that this is the expected behavior and therefore we should update the model as suggested.
On the long run, one could consider of making this default for redrawing - what do you think?
I would suggest two small additions to this PR:
- Could you please update the new firing rates in the code as they are used for downscaling?
- To make the documentation clearer (see Add documentation on discretization of uniformly distributed delays #2452), I would suggest to mention there that this effect not only appears for the uniform distribution but also for the normal distribution.
|
I've adjusted the mean rates and also added a sentence to the documentation. Please review again. |
heplesser
approved these changes
Dec 2, 2022
|
@heplesser I also saw that the reference data required an update. Can you review again? |
heplesser
approved these changes
Dec 6, 2022
terhorstd
added
I: Behavior changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #2503.
The changes applied by this pull request, slightly change the behavior of the cortical microcircuit (see #2503). It should therefore be discussed whether this is desired or not.