Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pynestkernel compatible with NumPy 1.24 #2571

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Make pynestkernel compatible with NumPy 1.24 #2571

merged 2 commits into from
Dec 21, 2022

Conversation

heplesser
Copy link
Contributor

This fixes #2570 following the suggestions provided in the NumPy 1.20.0 release notes: https://numpy.org/doc/stable//release/1.20.0-notes.html#using-the-aliases-of-builtin-types-like-np-int-is-deprecated

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: Critical Needs to be addressed immediately I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Dec 20, 2022
@heplesser heplesser added this to the NEST 3.4 milestone Dec 20, 2022
@heplesser heplesser added this to In progress in PyNEST via automation Dec 20, 2022
Helveg
Helveg approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@Helveg Helveg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! just wondering why we compare to the "C types" with np.bool_ and np.int_ and not the Python types bool and int? The article said the replacement was identical

@heplesser
Copy link
Contributor Author

OK! just wondering why we compare to the "C types" with np.bool_ and np.int_ and not the Python types bool and int? The article said the replacement was identical

I have changed to plain data types now.

clinssen
clinssen requested changes Dec 20, 2022
View reviewed changes
pynest/pynestkernel.pyx Show resolved Hide resolved
PyNEST automation moved this from In progress to Review Dec 20, 2022
@heplesser heplesser requested review from clinssen and removed request for jougs December 20, 2022 21:42
@clinssen clinssen mentioned this pull request Dec 21, 2022
Merged
@heplesser heplesser merged commit e2b16d4 into nest:master Dec 21, 2022
PyNEST automation moved this from Review to Done Dec 21, 2022
@heplesser heplesser deleted the fix-2570-numpy-long branch December 21, 2022 12:28
@nicolossus nicolossus mentioned this pull request Dec 22, 2022
Merged
@jessica-mitchell jessica-mitchell mentioned this pull request Jan 4, 2023
Closed
@RCagnol RCagnol mentioned this pull request Jan 11, 2023
Closed
@nicolossus nicolossus mentioned this pull request Mar 1, 2023
Closed
@heplesser heplesser mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helveg Helveg Helveg approved these changes

@clinssen clinssen clinssen approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Critical Needs to be addressed immediately T: Bug Wrong statements in the code or documentation
Projects
PyNEST
  
Done
Milestone
NEST 3.4
Development

Successfully merging this pull request may close these issues.

18 Pytests fail when testing against NumPy 1.24
3 participants
@heplesser @Helveg @clinssen