-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert multimeter test from SLI to Python implementation #2652
Conversation
I am not sure why the Python tests fail here. It is again the numpy datatype problem, it seems, but that was fixed with #2571 and this PR does not touch that code. Also, all tests pass on my branch (https://github.com/heplesser/nest-simulator/actions/runs/4505551444) and locally on my machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heplesser To me it looks like it is the static code check that fails? See comments. I also made a suggestion for how we can obtain models with certain properties.
@nicolossus The static checks now pass, we now install an up-to-date pycodestyle via pip; previously, we took an old version from a system location, thus the trouble with the :=. I don't think the models() function an improvement in this case so I have not adopted it yet. |
@heplesser I see, thanks for adding an up-to-date installation. I agree that the if ('recordables' in (dflts := nest.GetDefaults(model)) and dflts['recordables']) should be changed to (in my opinion) the more concise and readable if nest.GetDefaults(model).get('recordables') (Note |
You are right, I didn't realize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Co-authored-by: Nicolai Haug <39106781+nicolossus@users.noreply.github.com>
This PR provides a polished version of the Python implementation of the multimeter test ported from SLI.