Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make exception-name Python compatible #2649

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Make exception-name Python compatible #2649

merged 1 commit into from
Mar 22, 2023

Conversation

clinssen
Copy link
Contributor

This allows me to do:

@pytest.mark.xfail(strict=True, raises=nest.NESTErrors.CppException)

which before was not possible because a class cannot have a + character in its name.

@clinssen clinssen changed the title Change syntax of CppExpresion Change syntax of CppException Mar 22, 2023
@heplesser heplesser changed the title Change syntax of CppException Make exception name Python compatible Mar 22, 2023
@heplesser heplesser added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know labels Mar 22, 2023
@heplesser heplesser merged commit 4bd7a82 into nest:master Mar 22, 2023
@terhorstd terhorstd added T: Maintenance Work to keep up the quality of the code and documentation. and removed T: Enhancement New functionality, model or documentation labels Jun 23, 2023
@terhorstd terhorstd changed the title Make exception name Python compatible Make exception-name Python compatible Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@med-ayssar med-ayssar med-ayssar approved these changes

Assignees
No one assigned
Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Kernel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clinssen @heplesser @med-ayssar @terhorstd