Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of extension modules after change to static helper libraries #2659

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

jougs
Copy link
Contributor

@jougs jougs commented Apr 13, 2023

This fixes build problems for extension modules by removing non-existing libraries from CMakeLists.txt

@jougs jougs added T: Bug Wrong statements in the code or documentation S: Critical Needs to be addressed immediately I: External API Developers of extensions or other language bindings may need to adapt their code labels Apr 13, 2023
@jougs jougs requested review from clinssen and pnbabu April 13, 2023 14:13
@jougs jougs added this to To do in Build system and CI via automation Apr 13, 2023
@jougs jougs self-assigned this Apr 13, 2023
@jougs
Copy link
Contributor Author

jougs commented Apr 14, 2023

Merging with single approval due to severity.

@jougs jougs merged commit b905eb9 into nest:master Apr 14, 2023
6 checks passed
Build system and CI automation moved this from To do to Done Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: External API Developers of extensions or other language bindings may need to adapt their code S: Critical Needs to be addressed immediately T: Bug Wrong statements in the code or documentation
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants