Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in existing CopyModel Pytest and remove obsolete SLI test #2676

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Fix typo in existing CopyModel Pytest and remove obsolete SLI test #2676

merged 1 commit into from
Apr 24, 2023

Conversation

suku248
Copy link
Contributor

@suku248 suku248 commented Apr 24, 2023

No description provided.

@jougs jougs self-requested a review April 24, 2023 13:37
@jougs jougs added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know labels Apr 24, 2023
@jougs jougs added this to In progress in Automated testing via automation Apr 24, 2023
jougs
jougs approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial, so merging without second review

Automated testing automation moved this from In progress to Reviewer approved Apr 24, 2023
@jougs jougs changed the title Fix typo in existing copy-model pytest and remove obsolete sli test Fix typo in existing CopyModel Pytest and remove obsolete SLI test Apr 24, 2023
@jougs jougs merged commit fe55d98 into nest:sli_tests_to_py Apr 24, 2023
2 of 3 checks passed
Automated testing automation moved this from Reviewer approved to Done Apr 24, 2023
@suku248 suku248 deleted the sli2py_test_copymodel branch April 28, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
No open projects
Automated testing
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suku248 @jougs