Microcircuit model quick fix for issue #2741 #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This quickfix is just the right fix: One should never call any Since it is a small fix to informational output in an example, I will merge without second review. The failing sphinx_rtd test is due to a configuration error (see #2753), so it should not block merging this PR. |
heplesser
added
T: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes a quick fix for the MPI deadlock at the Python API level when accessing kernel information with a subset of the MPI processes available (cf issue #2741) in the microcircuit model.
In the model, this bug is caused by the __setup_next function in network.py#L263 when printing out the rng seed and total number of virtual processes only by rank 0.
Although this pull request does not fix the issue causing this bug, the proposed quickfix does not alter the behavior of the model in any way.