Require Cython >= 0.29.14 to avoid tp_print problem on Read the Docs #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
T: Bug
|
The rationale is the RTD environment, it supports only Python 3.8, and the first packages have started appearing whose bleeding edge versions are incompatible with Python 3.8 Our |
jougs
requested changes
May 2, 2023
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
jougs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a4673ce broke sphinx_rtd testing. This PR fixes that.
Python 3.9 removed
tp_printdeep in the system, which requires extra care on Cython's part when handling different Python versions. This is only handled properly from 0.29.14 onwards (https://cython.readthedocs.io/en/latest/src/changes.html#id106), so this PR hikes that requirement. Otherwise, sphinx_rtd tests fail because Cython cannot be built, see, e.g., https://github.com/nest/nest-simulator/actions/runs/4831505004/jobs/8609059706?pr=2749#step:4:845What was anyways the rationale behind fixing all packages to exact versions? When should they be updated?