-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Music cont out proxy #280
Music cont out proxy #280
Conversation
Hello @uahic , TravisCI is complaining about the formatting of the code. Please follow the instructions on our developer space on formatting the code with clang-format. |
@tammoippen I really did all the checks now and I used some vim plugins for clang-format but also did it via command line. Travis still complaints because of some line breaks but they are enforced by the screen width of 80 which is set in the .clang-format file. I am a bit lost ... |
Hello @uahic, |
…otics/nest-simulator into music_cont_out_proxy
This reverts commit 16647fb.
This reverts commit d9faf8e.
@weidel-p Can you please look into this PR? Thank you. |
I found a bug in my model in case when the ports are not correctly mapped, a patch will follow ASAP |
Update: the error seems to originate from a message input port (segfault). The segfault actually happens in the music lib if port names in the music conf and published names in the scripts does not match, regardless of the model |
…h the Port's map() function
…nt formatting changes
synmodel.empty() == false && "synapse 'static_synapse' not available" ); | ||
|
||
const index synmodel_id = static_cast< index >( synmodel ); | ||
std::vector< long_t >::const_iterator t; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
long_t
→ long
…urce and header file
@jougs Changed long_t and double_t to the standard type names |
👍 music_cont_out_proxy_example successfully tested with music v1.1.15 ! There is no dependency on the custom music branch any more. |
@gtrensch |
@uahic: Can you please provide the exact error messages? Just from your verbal description it does not become clear what the problem is. I.e. what are the SLI commands you're running and what's the error message you receive? From the code it looks as if everything should work. And if it does from Python, this hints at a problem with your SLI code. |
Using the SLI interpreter the output is as follows: SLI ] /music_cont_out_proxy Create /bla Set I will recompile NEST, possibly the currently installed version does not include the proxy |
I just compiled your branch and calling |
Please note that |
@jougs Thanks for the hint! And yep, after re-compiling it works. Next week there should be some time to spare for creating the SLI test's/examples. |
I've wrote half of the unit-test and hopefully will be able to deliver until the end of the week, currently I am pretty busy with project work and want to excuse that I did not have enough time to review Jochen's pull requests |
This pull request has been replaced by PR #798 and can be closed. |
New neuron type to support forwarding continuous values via the MUSIC continuous output port.
Notes: