Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port test_sinusoidal_poisson_generator from SLI-2-Py #2813

Merged
merged 12 commits into from
Jun 28, 2023
Merged

Port test_sinusoidal_poisson_generator from SLI-2-Py #2813

merged 12 commits into from
Jun 28, 2023

Conversation

nicolossus
Copy link
Member

@nicolossus nicolossus commented Jun 1, 2023 •
edited
Loading

The PR also improves the formatting of the instantaneous rate equations for both sinusoidal_poisson_generator and sinusoidal_gamma_generator. Moreover, the documentation for both generators is changed to be consistent with the changes introduced in #2815.

@nicolossus nicolossus mentioned this pull request Jun 5, 2023
Merged
jessica-mitchell
jessica-mitchell approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nicolossus looks good from my side

@heplesser heplesser self-assigned this Jun 28, 2023
@heplesser heplesser merged commit fb8265b into nest:master Jun 28, 2023
20 checks passed
@nicolossus nicolossus deleted the port_test_sinusoidal_poisson_generator branch June 28, 2023 13:14
@terhorstd terhorstd added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

@jougs jougs Awaiting requested review from jougs

Assignees

@heplesser heplesser

Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolossus @jessica-mitchell @heplesser @terhorstd