Port test_pulsepacket_generator from SLI-2-Py
#2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jougs @jessica-mitchell The SLI-2-Py port is quite one-to-one and straightforward. However, in porting the test I noticed some places in the documentation that could be improved by some small changes to the formatting. As a general style for documenting parameters I suggest: So far I have only made similar changes to the documentation on files I have touched, see #2813. I will make the corresponding changes elsewhere once we agree on the style. |
jessica-mitchell
requested changes
Jun 22, 2023
There was a problem hiding this comment.
Just a minor change,
and more to @jougs the stimulation_device userdocs in nestkernel has a NOINDEX label, and I don't think it's in Read the docs. I think this should be included somewhere, oder?
jessica-mitchell
approved these changes
Jun 27, 2023
heplesser
reviewed
Jun 28, 2023
testsuite/pytests/sli2py_stimulating/test_pulsepacket_generator.py
Outdated
Show resolved
Hide resolved
heplesser
reviewed
Jun 28, 2023
testsuite/pytests/sli2py_stimulating/test_pulsepacket_generator.py
Outdated
Show resolved
Hide resolved
heplesser
approved these changes
Jun 28, 2023
terhorstd
added
S: Normal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR also improves the formatting of the documentation for
stimulation_deviceandpulsepacket_generator.