Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update extension for API extractor #2965

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Update extension for API extractor #2965

merged 4 commits into from
Oct 5, 2023

Conversation

jessica-mitchell
Copy link
Contributor

@jessica-mitchell jessica-mitchell commented Sep 29, 2023 •
edited

This PR modifies the extract_api_functions.py script so it no longer outputs an unneeded JSON file, and moves the parts of the script that were in conf.py into one file in _ext.

Here is output (no change should have occurred)

@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 29, 2023
@jessica-mitchell jessica-mitchell added this to In progress in Documentation via automation Sep 29, 2023
@jessica-mitchell
Copy link
Contributor Author

@nicolossus @terhorstd I noticed that isort failed in the CI the first time even though when I committed it said it passed. I just ran isort on the file and that did the trick, but do you know why it would've passed on the commit initially? The error was only a new line missing.

@nicolossus
Copy link
Member

@nicolossus @terhorstd I noticed that isort failed in the CI the first time even though when I committed it said it passed. I just ran isort on the file and that did the trick, but do you know why it would've passed on the commit initially? The error was only a new line missing.

@jessica-mitchell Thanks for noticing! I have made a fix in #2968.

nicolossus
nicolossus approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@nicolossus nicolossus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me!

@jessica-mitchell
Copy link
Contributor Author

Merging with 1 reviewer as its documentation

@jessica-mitchell jessica-mitchell merged commit d70a893 into nest:master Oct 5, 2023
21 checks passed
Documentation automation moved this from In progress to Done Oct 5, 2023
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolossus nicolossus nicolossus approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jessica-mitchell @nicolossus