Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow isort pre-commit to make in-place changes #2968

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Allow isort pre-commit to make in-place changes #2968

merged 1 commit into from
Oct 20, 2023

Conversation

nicolossus
Copy link
Member

This PR removes the --diff flag from the isort pre-commit hook, thus allowing isort to make in-place changes instead of just showing the changes isort would make.

@nicolossus nicolossus added S: High Should be handled next T: Bug Wrong statements in the code or documentation I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 29, 2023
@nicolossus nicolossus mentioned this pull request Sep 29, 2023
Merged
@heplesser
Copy link
Contributor

Minimal flag to isort pre-commit hook, thus merging with single review.

@heplesser heplesser merged commit 6b01ae5 into nest:master Oct 20, 2023
21 checks passed
@nicolossus nicolossus deleted the fix_isort_precommit branch October 29, 2023 10:08
@terhorstd terhorstd mentioned this pull request Nov 21, 2023
Open
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicolossus @heplesser