-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have target/host triples "arch-vendor-os" as in autotools #326
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
# cmake/GetTriple.cmake | ||
# | ||
# This file is part of NEST. | ||
# | ||
# Copyright (C) 2004 The NEST Initiative | ||
# | ||
# NEST is free software: you can redistribute it and/or modify | ||
# it under the terms of the GNU General Public License as published by | ||
# the Free Software Foundation, either version 2 of the License, or | ||
# (at your option) any later version. | ||
# | ||
# NEST is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU General Public License | ||
# along with NEST. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
# Based on libcxx/cmake/Modules/GetTriple.cmake | ||
|
||
# Define functions to get the host and target triple. | ||
|
||
function(get_host_triple out out_arch out_vendor out_os) | ||
# Get the architecture. | ||
set( arch "${CMAKE_HOST_SYSTEM_PROCESSOR}" ) | ||
# i686 is an enhanced version of x86 | ||
if ( arch STREQUAL "x86" ) | ||
set( arch "i686" ) | ||
endif () | ||
|
||
# Get the vendor. | ||
if ( "${CMAKE_HOST_SYSTEM_NAME}" MATCHES "^Darwin.*" ) | ||
set( vendor "apple" ) | ||
else () | ||
set( vendor "pc" ) | ||
endif () | ||
|
||
# Get os. | ||
if ( "${CMAKE_HOST_SYSTEM_NAME}" STREQUAL "Windows" ) | ||
set( os "win32" ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wouldn't just "win" be more correct on current versions of that OS? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not so sure how relevant this actually is, given that NEST is not officially supported on Windows ("we do not tests this regularly [building on Windows] and do not support NEST under Cygwin at present"), but the lines are only relevant, if the host system name is |
||
else () | ||
string( TOLOWER "${CMAKE_HOST_SYSTEM_NAME}" os ) | ||
endif () | ||
|
||
set( triple "${arch}-${vendor}-${os}" ) | ||
|
||
# return values | ||
set( ${out} ${triple} PARENT_SCOPE ) | ||
set( ${out_arch} ${arch} PARENT_SCOPE ) | ||
set( ${out_vendor} ${vendor} PARENT_SCOPE ) | ||
set( ${out_os} ${os} PARENT_SCOPE ) | ||
|
||
message( STATUS "Host triple: ${triple}" ) | ||
endfunction () | ||
|
||
|
||
function(get_target_triple out out_arch out_vendor out_os) | ||
# Get the architecture. | ||
set( arch "${CMAKE_SYSTEM_PROCESSOR}" ) | ||
# i686 is an enhanced version of x86 | ||
if ( arch STREQUAL "x86" ) | ||
set( arch "i686" ) | ||
endif () | ||
|
||
# Get the vendor. | ||
if ( "${CMAKE_SYSTEM_NAME}" MATCHES "^Darwin.*") | ||
set( vendor "apple" ) | ||
else () | ||
set( vendor "pc" ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would this set vendor to pc also for BlueGene and K? |
||
endif () | ||
|
||
# Get os. | ||
if ( "${CMAKE_SYSTEM_NAME}" STREQUAL "Windows" ) | ||
set( os "win32" ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See above |
||
else () | ||
string( TOLOWER "${CMAKE_SYSTEM_NAME}" os ) | ||
endif () | ||
|
||
set(triple "${arch}-${vendor}-${os}") | ||
|
||
# return values | ||
set( ${out} ${triple} PARENT_SCOPE ) | ||
set( ${out_arch} ${arch} PARENT_SCOPE ) | ||
set( ${out_vendor} ${vendor} PARENT_SCOPE ) | ||
set( ${out_os} ${os} PARENT_SCOPE ) | ||
|
||
message(STATUS "Target triple: ${triple}") | ||
endfunction() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the name
GetTriple
for this file. Can you make it more specific, please?Maybe
DetermineArchitecture` or something like this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In autotools they are called
TypeTriplets
. Other cmake implementations call thisGetTriplet.cmake
, orTriplet.cmake
[1] [2]. As this is specifically for the autotools triplets, I think the name triplet should be contained.