-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to issue #696 #710
Fix to issue #696 #710
Conversation
The newly added testcase is apparently failing when ran with @heplesser @jougs Could you elaborate on how to properly define
When running
It might also be useful to make this more transparent for all users (?). |
@mhoff The call signature of the SLI
|
I think I see the problem now. I have used the pymusic interface to write the counterpart of the nest-node. But the testsuite does not support python-based nodes in the MUSIC tests. We could change this by supporting python-based nodes, e.g.
or we can rewrite this test to not use python-based nodes. Which solution is preferred? |
@mhoff: I would prefer if the test was written in pure SLI as this guarantees that the tests also run in situations in which Python is not available. Feel free to ask if you require assistance with this. I'm currently out of office, so please don't expect an immediate response. I'll do my best to still answer quickly, though. |
I understand. The test is functional now. I reduced the receiver to a very simple sli-based node. The functionality is now reduced to setting up the connection and sending some spikes. The only assertion is that the program does not crash. This should suffice as a primitive regression test for the mapping problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good too me, I just have a request for a model change.
|
||
/subnet Create /NG Set | ||
NG ChangeSubnet | ||
/iaf_neuron N_NEURONS Create pop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As iaf_neuron will soon be removed from NEST, could you change this to /iaf_psc_alpha ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks!
@jougs Are you satisfied with the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this looks very good! Many thanks again.
@heplesser: can you please pull master into your subnet-removal branch and remove subnet according to current standards once this is merged? I'll pull from there then. Thanks! |
This is a fix to issue #696. The connection function of the ConnectionManager has been updated to correctly handle MUSIC proxy nodes. A regression test has been added.