New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixed on cmake with user modules #870

Merged
merged 1 commit into from Feb 13, 2018

Conversation

Projects
None yet
4 participants
@jgarridoalcazar
Contributor

jgarridoalcazar commented Dec 11, 2017

User module headers are now searched on a specific module folder (<nest_prefix>/include/<module_name>/). It is intended to solve issue #868.

Bug fixed on cmake with user modules
User module headers are now searched on a specific module folder (<nest_prefix>/include/<module_name>/). It is intended to solve issue #868.
@tammoippen

This comment has been minimized.

Show comment
Hide comment
@tammoippen

tammoippen Dec 11, 2017

Contributor

Good catch. Must have missed that in #844. 👍 from my side.

Contributor

tammoippen commented Dec 11, 2017

Good catch. Must have missed that in #844. 👍 from my side.

jgarridoalcazar added a commit to jgarridoalcazar/nest-simulator that referenced this pull request Dec 11, 2017

Fixing issue on linking user module libraries with recent GCC versions
This changes are intended to fix issue #869.

It explicitely defines "-Wl,--no-as-needed" linking flag on nest executable, nest library and pynest library. By default, recent versions of GCC set --as-needed flag. This option allows the linker to ignore, i.e., not link against, some of the libraries supplied on its command line if they are not actually used by the shared library that is being created. This option avoids external modules to be linked in NEST even if they are defined with -Dexternal-modules=....

By setting --no-as-needed GCC will link against all the libraries explicitely indicated (including external modules). It may produce slower executable/library startup if more libraries are added than required.

This PR requires PR #870 to be added in order to fix issue #868.

This PR has only been tested with GCC 5.4.0 and Ubuntu 16.04. It should be tested on different compilers and OS.

@heplesser heplesser requested review from tammoippen and heplesser Dec 21, 2017

@Silmathoron

All good from me too 👍

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Feb 13, 2018

Contributor

@jgarridoalcazar Thanks for fixing this!

Contributor

heplesser commented Feb 13, 2018

@jgarridoalcazar Thanks for fixing this!

@heplesser heplesser merged commit 03ef9c3 into nest:master Feb 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jgarridoalcazar jgarridoalcazar deleted the jgarridoalcazar:fix-ext-module-include-path branch Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment