Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZResource and ZFile.ParseXML code should be refactored #48

Closed
Kenix3 opened this issue Jan 4, 2021 · 0 comments
Closed

ZResource and ZFile.ParseXML code should be refactored #48

Kenix3 opened this issue Jan 4, 2021 · 0 comments

Comments

@Kenix3
Copy link
Contributor

Kenix3 commented Jan 4, 2021

ZResource and it's descendent classes should use more polymorphism. There is not a huge amount of consistency in method names right now for the extraction code entry point. This should be an overridden method from ZResource for each type.
Further, the code in ZFile.ParseXML for each type should be moved to a method in ZResource and overridden methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants