Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inherit directive and extensions in type helpers, compile unique directives #1363

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

madzhup
Copy link
Contributor

@madzhup madzhup commented Feb 5, 2021

This closes #1351.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

  1. Directive and Extensions decorators does not inherit when using mapped types.
  2. Directives metadata applying multiple times

Issue Number: #1351

What is the new behavior?

  1. Directive and Extensions decorators is inherited when using mapped types.
  2. Skip adding existing directive metadata

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@madzhup
Copy link
Contributor Author

madzhup commented Mar 1, 2021

@kamilmysliwiec, can you please review this PR and merge it, if it is ok?

@kamilmysliwiec kamilmysliwiec merged commit 2d4c1a9 into nestjs:master Mar 17, 2021
@kamilmysliwiec
Copy link
Member

This looks great, thank you! It will be added in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directive and Extensions metadata does not inherit when using mapped types.
2 participants