Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression > Copying assets is broken on Windows devices #2429

Closed
2 tasks done
ErazerBrecht opened this issue Dec 30, 2023 · 1 comment
Closed
2 tasks done

Regression > Copying assets is broken on Windows devices #2429

ErazerBrecht opened this issue Dec 30, 2023 · 1 comment

Comments

@ErazerBrecht
Copy link

Did you read the migration guide?

  • I have read the whole migration guide

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Potential Commit/PR that introduced the regression

No response

Versions

8.1.X -> 8.2.X

Describe the regression

When running npm run start you will get the following error:

Error An error occurred during the assets copying process. cant go up that far

This only seems to be the case in Windows.
In our docker containers in PROD everything works (Linux containers). Also our MacOS developers don't have the problem.

Minimum reproduction code

Adding a file to the assets config in nest-cli.json

 "assets": ["settings.json"]

Quickly created a git repro to showcase the problem
https://github.com/ErazerBrecht/nestjs_regression

Master branch latest NestJS version => Doesn't work
Reverted branch NestJS 10.1.X => Works

Expected behavior

The expected behavior is the as-is behavior in the 10.1.X version.
It should just copy the 'settings.json' file to the dist folder.

Other

This issue might be related:
#2397
But that issue describes the files aren't copied in my case the cli already "crashes". It also sounds like it only happens with a glob pattern. Which I don't use here.

@kamilmysliwiec
Copy link
Member

Fixed in 10.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants