HttpModule async registration

[Morb0]

I'm submitting a...

[ ] Regression 
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

HttpModule dont have async registration because of this, it is not possible to set config variables.

Expected behavior

Async module registation with the possibility of inject dependencies through inject

Minimal reproduction of the problem with instructions

imports: [
  HttpModule.register({
    baseURL: 'http://example.com',
    headers: {
      authorization: `Bearer ${configService.get('AUTH_TOKEN')}`,
    }
  })
]

What is the motivation / use case for changing the behavior?

More convenient use of the module

Environment

Nest version: 5.1.0

 
For Tooling issues:
- Node version: 10.11.0  
- Platform: Windows 

Others:

[kamilmysliwiec]

Done in #1347

[kamilmysliwiec]

Added in 5.5.0.

[cschroeter]

@kamilmysliwiec

Instead of

export interface HttpModuleOptions extends AxiosRequestConfig {
}
export interface HttpModuleOptionsFactory {
    createHttpOptions(): Promise<HttpModuleOptions> | HttpModuleOptions;
}
export interface HttpModuleAsyncOptions extends Pick<ModuleMetadata, 'imports'> {
    useExisting?: Type<HttpModuleOptions>;
    useClass?: Type<HttpModuleOptions>;
    useFactory?: (...args: any[]) => Promise<HttpModuleOptions> | HttpModuleOptions;
    inject?: any[];
    extraProviders?: Provider[];
}

shouln't it be

export interface HttpModuleOptions extends AxiosRequestConfig {
}
export interface HttpModuleOptionsFactory {
    createHttpOptions(): Promise<HttpModuleOptions> | HttpModuleOptions;
}
export interface HttpModuleAsyncOptions extends Pick<ModuleMetadata, 'imports'> {
    useExisting?: Type<HttpModuleOptionsFactory>;
    useClass?: Type<HttpModuleOptionsFactory>;
    useFactory?: (...args: any[]) => Promise<HttpModuleOptions> | HttpModuleOptions;
    inject?: any[];
    extraProviders?: Provider[];
}

[kamilmysliwiec]

Would you like to create PR @cschroeter ?

[cschroeter]

@kamilmysliwiec ah sorry haven't seen ur reply. will try to creat a pr after holiday season next year

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.