Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Module should create express server automatically #326

Closed
xeoneux opened this issue Dec 23, 2017 · 2 comments · Fixed by #327
Closed

Testing Module should create express server automatically #326

xeoneux opened this issue Dec 23, 2017 · 2 comments · Fixed by #327

Comments

@xeoneux
Copy link
Contributor

xeoneux commented Dec 23, 2017

I'm submitting a...


[ ] Regression 
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

TestingModule.createNestApplication function requires an optional express server. It won't create one automatically if not provided.

Expected behavior

TestingModule.createNestApplication function should create an express server automatically if not provided in the parameters.

Minimal reproduction of the problem with instructions

Not required

What is the motivation / use case for changing the behavior?

To abstract away express and its import and provide a default fallback

Environment


Nest version: 4.4.2

 
For Tooling issues:
- Node version: 9.3.0  
- Platform: OS X High Sierra  

Others: N/A

@kamilmysliwiec
Copy link
Member

Hi @xeoneux,
I have merged your PR. It'll be a part of 4.5.3 :)

@lock
Copy link

lock bot commented Sep 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants