NestApplication does not correctly implement INestApplication

[ghost]

Bug Report

ERROR in C:/_myplace/gen3/platform-libs/node_modules/@nestjs/core/nest-application.d.ts(44,5):
TS2416: Property 'enableCors' in type 'NestApplication' is not assignable to the same property in base type 'INestApplication'.
Type '(options?: CorsOptions | undefined) => void' is not assignable to type '(options?: CorsOptions | undefined) => this'.
Type 'void' is not assignable to type 'this'.

It is defined as void

nest/packages/common/interfaces/nest-application.interface.ts

Line 29 in 7a65564

enableCors(options?: CorsOptions): void;

Implement with a return type

nest/packages/core/nest-application.ts

Line 218 in 7a65564

public enableCors(options?: CorsOptions): void {

The only use of the function actually uses the return type

nest/packages/core/nest-application.ts

Line 106 in 7a65564

return this.enableCors();

[kamilmysliwiec]

Please, provide a minimal repository which reproduces your issue.

[msanguineti]

@kamilmysliwiec I do not think it is closed

I am getting the same error after updating from v6.10.14 to v6.11.7

node_modules/@nestjs/core/nest-application.d.ts:44:5 - error TS2416: Property 'enableCors' in type 'NestApplication' is not assignable to the same property in base type 'INestApplication'.
  Type '(options?: CorsOptions) => void' is not assignable to type '(options?: CorsOptions) => this'.
    Type 'void' is not assignable to type 'this'.

44     enableCors(options?: CorsOptions): void;

It was changed here #3656

[kamilmysliwiec]

Please, ensure that your @nestjs/common, @nestjs/core, and @nestjs/platform-{express/fastify} versions match.

[msanguineti]

That was exactly the problem... it was failing in CI when updating deps, but only because it was updating one dep at the time... sorry.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.