Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastify Adapter not processing requests #659

Closed
aserplussm opened this issue May 9, 2018 · 6 comments
Closed

Fastify Adapter not processing requests #659

aserplussm opened this issue May 9, 2018 · 6 comments

Comments

@aserplussm
Copy link

I'm submitting a...


[ ] Regression 
[X] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

NestJS does not process requests when Fastify Adapter has been enabled.

Expected behavior

NestJS should process requests and route to the appropriate controller method

Minimal reproduction of the problem with instructions

  1. Clone NestJS fastify example
  2. Run yarn install in terminal
  3. Select one of the following versions:
  • 5.0.0-rc.4
  • 5.0.0-rc.3
  • 5.0.0-rc.2
  1. Run yarn start in terminal
  2. Open browser and paste 'http://localhost:3000/cats' into the address bar
  3. Notice the request is not handled and no logs appear in the terminal

What is the motivation / use case for changing the behavior?

Environment


Nest version: >= 5.0.0-rc.2 

 
For Tooling issues:
- Node version: 8.1.0
- Platform:  docker container (node:8.1.0-alpine) 

Others:

@aserplussm aserplussm changed the title Fastify Adapter not working for requests Fastify Adapter not processing requests May 9, 2018
@kamilmysliwiec
Copy link
Member

I cannot reproduce your issue. Tested using sample, works like a charm.

@aserplussm
Copy link
Author

Thanks for your response.

We ran more tests and this is only occurring when running in a docker container. We are investigating more on our end.

@EricAWE
Copy link

EricAWE commented Jun 7, 2018

Hey @aserplussm,

I'm falling in the same issue when I'm in a docker container.
I was wondering if you have find a solution to fix the issue ?

Thanks,

@aserplussm
Copy link
Author

@EricAWE We were able to figure out that it was an issue with fastify on docker. Check out this isssue on the fastify GitHub repo that outlines the problem and a solution. This worked for us :-)

@EricAWE
Copy link

EricAWE commented Jun 8, 2018

@aserplussm Thanks, works like a charm for me

@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants