You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there an existing issue that is already proposing this?
I have searched the existing issues
Is your feature request related to a problem? Please describe it
constpostfixId=this.getOptionsProp(this.options,'postfixId')||'-server';// append a unique id to the clientId and groupId// so they don't collide with a microservices clientthis.clientId=(clientOptions.clientId||KAFKA_DEFAULT_CLIENT)+postfixId;this.groupId=(consumerOptions.groupId||KAFKA_DEFAULT_GROUP)+postfixId;
Is there any reason postfixId is forced?
(By forced I mean undefined || '-server' = '-server', '' || '-server' = '-server' )
Since I need to migrate old server and it's kafka Consumers to new nestJS server,
I need to preserve kafka consumer's old name.
Of course, I can do something like preserve old name delete-gift as with name 'delete' and postfixId '-gift',
but which is pretty implicit way, and I'd love to avoid it.
Describe the solution you'd like
Will it be possible to fix code to make it possible to set postfixId as '' ? (empty string)
Since as @kamilmysliwiec clarified, there is no specific reason to force postfixId, and @micalevisk has done making PR for me.
I will close this issue, thank you to both of you.
Is there an existing issue that is already proposing this?
Is your feature request related to a problem? Please describe it
Is there any reason postfixId is forced?
(By forced I mean undefined || '-server' = '-server', '' || '-server' = '-server' )
Since I need to migrate old server and it's kafka Consumers to new nestJS server,
I need to preserve kafka consumer's old name.
Of course, I can do something like preserve old name delete-gift as with name 'delete' and postfixId '-gift',
but which is pretty implicit way, and I'd love to avoid it.
Describe the solution you'd like
Will it be possible to fix code to make it possible to set postfixId as '' ? (empty string)
Teachability, documentation, adoption, migration strategy
I don't know
What is the motivation / use case for changing the behavior?
This change will enable old kafka topic to be consumed by new nestJS server
The text was updated successfully, but these errors were encountered: