Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common) add log levels (error, info, etc union) #2813

Merged
merged 7 commits into from
Aug 26, 2019

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1838

What is the new behavior?

Example:

NestFactory.create(AppModule, {
   logger: ['info', 'warning'],
});

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kamilmysliwiec kamilmysliwiec added this to the 6.6.0 milestone Aug 26, 2019
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 6.6.0 August 26, 2019 10:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4306

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 95.248%

Files with Coverage Reduction New Missed Lines %
packages/microservices/client/client-proxy.ts 1 98.11%
packages/core/injector/module.ts 9 86.87%
Totals Coverage Status
Change from base Build 4296: -0.02%
Covered Lines: 3648
Relevant Lines: 3830

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit e974283 into 6.6.0 Aug 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/log-levels branch August 26, 2019 12:11
@lock
Copy link

lock bot commented Nov 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants