Feature/4752 file validator pipe new #9707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Pull Request Test Coverage Report for Build 410460da-4fe3-4bbf-9ea1-573f08856c56
💛 - Coveralls |
|
@thiagomini could you rebase to use the |
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 17.0.36 to 17.0.38. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 12.4.3 to 12.5.0. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v12.4.3...v12.5.0) --- updated-dependencies: - dependency-name: lint-staged dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [point-of-view](https://github.com/fastify/point-of-view) from 5.3.0 to 6.2.1. - [Release notes](https://github.com/fastify/point-of-view/releases) - [Commits](fastify/point-of-view@v5.3.0...v6.2.1) --- updated-dependencies: - dependency-name: point-of-view dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [kafkajs](https://github.com/tulios/kafkajs) from 2.0.1 to 2.0.2. - [Release notes](https://github.com/tulios/kafkajs/releases) - [Changelog](https://github.com/tulios/kafkajs/blob/master/CHANGELOG.md) - [Commits](tulios/kafkajs@v2.0.1...v2.0.2) --- updated-dependencies: - dependency-name: kafkajs dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
fix import to relative path, the alias was causing cyclic references
add curly braces to if statement for consistency
add tests for parse file pipe builder and refactor associated classes
thiagomini
force-pushed
the
feature/4752-file-validator-pipe-new
branch
from
b059f50
to
2ad6be0
Compare
|
Closed to create again for 9.0.0 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We don't have validation options out of the box for the
@UploadedFile()decorator.Issue Number: #4752
What is the new behavior?
We can use some default validators using pipes:
MaxFileSizeValidatorandFileTypeValidator. Also, we can pass our own validators if they follow theFileValidatorinterface.Does this PR introduce a breaking change?
Other information
This still needs tests to verify if it's actually working with files (e2e tests maybe?)
This is a continuation of a previous, stale PR