Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker files are being ignored in .gitignore #181

Closed
hiagodotme opened this issue Sep 25, 2020 · 1 comment
Closed

Docker files are being ignored in .gitignore #181

hiagodotme opened this issue Sep 25, 2020 · 1 comment

Comments

@hiagodotme
Copy link
Contributor

Hello guys, I'm starting the development of a new project. I chose nestjs because honestly it is the most complete framework I have ever seen, I really liked the documentation and the ecosystem.

I noticed something strange, I created a docker-compose.yml file and it is being ignored in the .gitignore file.

Are there any specific reasons for this? In our environment the node runs inside containers so that you don't have to install dependencies on the machines. In addition to the fact that continuous integration is part of the project, I believe that ignoring this file is not correct.

Thanks to personal attention!

@kamilmysliwiec
Copy link
Member

Fixed #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants