skip + take vs limit + offset poll

[bashleigh]

Seems like there are some conflicts between the default method of querying. I feel this is a bit of an opinionated choice in some cases and I also don't want to be bias! I personally would stick with limit + offset as it's perfect for simple queries however some people may differ.

Please could people vote for their perfered method, once I have enough votes say by end of November we can release a breaking change if required.

[csxcode]

Well, when use pagination with Limit & Offset, I have problems using joins as other people. I understand that I should use "Take and Skip" with joins, but what is the main difference, the performance?

[bashleigh]

@csxcode well it's looking pretty close atm so I think I might do a bit of research and see what the diff is (been a while since I've properly looked at query performance) and see if we can convince more people! If there's no performance difference then I guess we leave it?

[vjrngn]

I second @csxcode point. I don't think this is a question of only performance. Depending on the query "take and skip" may be preferable over "limit and offset".

[Elbarae1921]

Like it was said by the creator of typeorm:

use skip / take instead of limit / offset when you do joins with selection.

typeorm/typeorm#8014 (comment)

[Elbarae1921]

One issue I find though is when I have joins with selection and an orderBy clause. Neither take/skip nor limit/offset worked for me.

[ChamaraWP]

cloud someone shows me how to change the query type to TAKE_LIMIT. I couldn't find it in the documentation. sorry for commenting on the irrelevant issue.

[Elbarae1921]

@ChamaraWP

const result = await paginate(
    queryBuilder, 
    {
        limit: 10,
        page: 1,
        paginationType: PaginationTypeEnum.LIMIT_AND_OFFSET
    }
);

[bashleigh]

I think after several extra months, it's pretty unanimous that limit and offset is the prefered method.
After doing some reading a long time ago here is a general gist to remind others

Limit & Offset

Uses query based method for selection

Skip & Take

Uses javascript filter to filter results