Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lazy for state value in StateChange #1159

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

Barsonax
Copy link
Contributor

@Barsonax Barsonax commented Aug 24, 2024

Breaking change

Proposed change

Use lazy for state value in StateChange. This solves a undefined JsonElement throwing a invalidoperation exception in tests.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration are added/changed:

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82%. Comparing base (6881467) to head (dc648bd).
Report is 1 commits behind head on main.

Files Patch % Lines
...sModel/NetDeamon.HassModel/Entities/StateChange.cs 90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1159   +/-   ##
====================================
  Coverage    82%     82%           
====================================
  Files       190     190           
  Lines      3781    3782    +1     
  Branches    425     423    -2     
====================================
+ Hits       3115    3116    +1     
  Misses      499     499           
  Partials    167     167           
Flag Coverage Δ
unittests 82% <90%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Barsonax Barsonax added the bug Something isn't working label Aug 24, 2024
@Barsonax Barsonax changed the title Make sure _jsonElement is filled with a default value so that Old and New do not throw invalid operation exception in tests Use lazy for state value in StateChange Aug 24, 2024
@Barsonax Barsonax added pr: bugfix and removed bug Something isn't working labels Aug 24, 2024
@Barsonax Barsonax force-pushed the feature/FixLazyLoadingOldNewInTests branch from 5053181 to 7b407e6 Compare August 24, 2024 19:33
… New do not throw

use lazy to remove branching from properties
@Barsonax Barsonax force-pushed the feature/FixLazyLoadingOldNewInTests branch from 7b407e6 to dc648bd Compare August 24, 2024 19:40
@FrankBakkerNl FrankBakkerNl merged commit 3713081 into main Aug 24, 2024
7 checks passed
@FrankBakkerNl FrankBakkerNl deleted the feature/FixLazyLoadingOldNewInTests branch August 24, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants