Events on ha context #478
Merged
Events on ha context #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helto4real
approved these changes
Oct 19, 2021
| eventProvider.GetEventDataOfType<ZhaEventData>("zha_event") | ||
| .Where(e => e.DeviceIeee == "84:71:27:ff:fe:40:78:7b") | ||
| .Subscribe(e => Console.WriteLine($"device {e.DeviceIeee} sent command: { e.Command} endpoint: {e.EndpointId}")); | ||
| ha.Events.Filter<ZhaEventData>("zha_event") |
There was a problem hiding this comment.
Ohh I really like the use of "Filter". We could always be even more specific in the Where clause if we need to.
| using System; | ||
| using System.Text.Json; | ||
|
|
||
| namespace NetDaemon.Model3.Common |
There was a problem hiding this comment.
Should we use HassModel as namespace instead of Model3?
| using NetDaemon.Model3.Entities; | ||
| using System; | ||
| using System.Reactive.Linq; | ||
| using NetDaemon.Model3.Entities; | ||
|
|
||
| namespace NetDaemon.Model3.Common |
There was a problem hiding this comment.
Same here. All Model3 -> HassModel
FrankBakkerNl
added a commit
to FrankBakkerNl/netdaemon
that referenced
this pull request
Oct 24, 2021
* Added Events to IHaContext * Remove unused variable * Fix comment
helto4real
pushed a commit
that referenced
this pull request
Oct 26, 2021
* Added Events to IHaContext * Remove unused variable * Fix comment
FrankBakkerNl
added a commit
to FrankBakkerNl/netdaemon
that referenced
this pull request
Oct 28, 2021
Re-added because it was lost in a merge conflict
FrankBakkerNl
added a commit
that referenced
this pull request
Oct 28, 2021
Ikcelaks
pushed a commit
to Ikcelaks/netdaemon
that referenced
this pull request
Dec 23, 2022
* Added Events to IHaContext * Remove unused variable * Fix comment
Ikcelaks
pushed a commit
to Ikcelaks/netdaemon
that referenced
this pull request
Dec 23, 2022
Re-added because it was lost in a merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: