Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Core APIs and properties of Card BO and dependencies. #98

Closed
rtxm opened this issue Nov 24, 2015 · 2 comments
Closed

Define Core APIs and properties of Card BO and dependencies. #98

rtxm opened this issue Nov 24, 2015 · 2 comments
Milestone

Comments

@rtxm
Copy link
Collaborator

rtxm commented Nov 24, 2015

Depends on #94, #96.

Core API

We distinguish to kinds of core API:

  • business methods (a.k.a. Component API)
  • internal methods

Internal methods are used by the component only. In particular, methods and callbacks for the views are found here.

Business methods and properties

  • set_title
  • get_title (or property)
  • delete: prepare component to be deleted. It's up to the column BO to actually delete it, and to the column Data Model to destroy the DataCard.

Internal methods and properties

View specific

Methods to move elsewhere

  • move_card: only Boards can do that.

Methods and properties to remove

  • column: remove from card API. If you need to communicate with parent, use comp.answer to send an event. Maybe still needed in features API.
  • must_reload_search, reload_search: send an event instead. See Centralize History feature at board level #85, bubbling events.
  • board: if you need to communicate with ancestor, send an event.

Features API

To be grouped apart, with comments. These functions will be moved to extensions when those have their own data models.

  • favorites: remove direct access to Column, use comp.answer to send an event.
  • weight
  • get_authorized_users: remove direct access to Column, use comp.answer to send an event.
  • get_authorized_users
  • get_available_labels: remove direct access to Column, use comp.answer to send an event.
  • *_member* methods: remove direct access to history/column, use comp.answer to send an event.
  • methods added during Card component : handle features in a generic manner. #96.
@rtxm rtxm changed the title Decouple Core APIs (Component and Internal) of Card BO from its parents. Define Core APIs and properties (Component and Internal) of Card BO and dependencies. Nov 25, 2015
@rtxm rtxm changed the title Define Core APIs and properties (Component and Internal) of Card BO and dependencies. Define Core APIs and properties of Card BO and dependencies. Nov 25, 2015
@rtxm
Copy link
Collaborator Author

rtxm commented Dec 1, 2015

I take it.

@rtxm
Copy link
Collaborator Author

rtxm commented Dec 16, 2015

Fixed in #138, #126

@rtxm rtxm closed this as completed Dec 16, 2015
@rtxm rtxm modified the milestone: Sprint1512 Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant