Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP Range search not working as expected #11601

Closed
zacho112 opened this issue Jan 27, 2023 · 2 comments · Fixed by #11697
Closed

IP Range search not working as expected #11601

zacho112 opened this issue Jan 27, 2023 · 2 comments · Fixed by #11697
Assignees
@kkthxbye-code
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@zacho112
Copy link
Contributor

NetBox version

v3.4.3

Python version

3.11

Steps to Reproduce

  1. Log into https://demo.netbox.dev
  2. Go to IP-Ranges
  3. Search for one of the IP ranges, eg. 192.168.1.50, or simply 192

Expected Behavior

All IP ranges with a matching substring of the search shows, kinda like ?q= works on ip_addresses. (It's the same for the API and pynetbox)

Observed Behavior

No results found.
Search in GUI and ?q= does not show any results at all.
?contains= seems to work when searching for an IP (with /cidr), and URL encodes the /. 192.168.1.66/22 does not work, but 192.168.1.66%2f22 works. But I can't get contains to work via pynetbox.
@zacho112 zacho112 added the type: bug A confirmed report of unexpected behavior in the application label Jan 27, 2023
@dsobon
Copy link

dsobon commented Jan 27, 2023

@zacho112 - do you mean "Quick search" instead of "Search"?
Or do you mean that "192.168.1.66" does not work in "Search"?

Quick search of "192" shows 0 results.
image
Quick search of "Future" shows 4 results.
image
"Search" of "192" shows 9 results
image

|

@zacho112
Copy link
Contributor Author

zacho112 commented Jan 27, 2023 •
edited
Loading

Yes, my bad, quick search it is. Searching for part of ip in the range. And also the 'query' ('?q=') via API ofc

@jsenecal jsenecal added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Jan 31, 2023
@kkthxbye-code kkthxbye-code self-assigned this Feb 8, 2023
kkthxbye-code pushed a commit to kkthxbye-code/netbox that referenced this issue Feb 8, 2023
Fixes netbox-community#11601 - Add partial lookup to IPRangeFilterSet
69c921a
@kkthxbye-code kkthxbye-code mentioned this issue Feb 8, 2023
Merged
@kkthxbye-code kkthxbye-code added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Feb 8, 2023
jeremystretch pushed a commit that referenced this issue Feb 8, 2023
@jeremystretch
Fixes #11601 - Add partial lookup to IPRangeFilterSet
f923728
jeremystretch added a commit that referenced this issue Feb 8, 2023
@jeremystretch
Changelog for #11032, #11582, #11601
b5da383
@jeremystretch jeremystretch mentioned this issue Feb 21, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kkthxbye-code kkthxbye-code

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #11601 - Add partial lookup to IPRangeFilterSet kkthxbye-code/netbox
4 participants
@kkthxbye-code @dsobon @jsenecal @zacho112