Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the related IPs list under the IP address view to a separate tab #12233

Closed
ThomasADavis opened this issue Apr 12, 2023 · 4 comments · Fixed by #12502
Closed

Move the related IPs list under the IP address view to a separate tab #12233

ThomasADavis opened this issue Apr 12, 2023 · 4 comments · Fixed by #12502
Assignees
@abhi1693
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@ThomasADavis
Copy link

NetBox version

v3.5-beta1

Feature type

Change to existing functionality

Proposed functionality

When you view the IP address page, there is table of related IP addresses. An example page is at https://demo.netbox.dev/ipam/ip-addresses/181/

This table really isn't related to the IP addresses, it's more of a query of the db, and gets the first X number of ip addresses from the subnet IP address is located in, where X is current default paging value. In the demo, this is 100.

The listed IP's are not the IP's from the before/after the current viewed IP address. The list starts at the beginning of the subnet.

The listed IP's are not paged, they are simply truncated to the default paging value.
If you pick a large default paging value, this can be 50 or more values. If your viewing a large subnet, with many IP's defined, you can have a very large table generated.

Replacing the related table with a direct link to the subnet IP addresses tab is better than looking at a related table that is either incomplete or not truly related.

I also remember the devices page also had a related table and was removed for some reason (looking for the issue related to this)

I've attached a set of screen shots that shows this, along with how the values presented are not truly related other than by subnet.

Screenshot_2023-04-12_10-53-26
Screenshot_2023-04-12_10-52-43

Use case

Removing this table would speed up the page load and remove a possible large db query.

It would also reduce the amount of scrolling need to view the full contents of the page.

Database changes

None.

External dependencies

None
@ThomasADavis ThomasADavis added the type: feature Introduction of new functionality to the application label Apr 12, 2023
@DanSheps
Copy link
Member

Maybe instead of removing it, perhaps moving it to another tab would be a better way to go.

@ThomasADavis
Copy link
Author

Found the feature request for the device related object..

#8083

@abhi1693
Copy link
Member

Moving it to a tab is probably better because in my setup related IPs are really helpful due to the way our infrastructure is implemented.

@jsenecal
Copy link
Contributor

I also vote for putting this in another view in a dedicated tab.

@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label May 4, 2023
@jeremystretch jeremystretch changed the title Remove the related IP's table from the IP address view. Move the related IPs list under the IP address view to a separate tab May 4, 2023
@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 5, 2023
@abhi1693 abhi1693 self-assigned this May 5, 2023
abhi1693 added a commit that referenced this issue May 5, 2023
@abhi1693
moves related ips to a tab #12233
235342e
@abhi1693 abhi1693 mentioned this issue May 5, 2023
Merged
jeremystretch added a commit that referenced this issue May 9, 2023
@abhi1693 @jeremystretch
Moves related ips to a tab (#12502)
6b19f15 
* moves related ips to a tab #12233

* Refactor IP address templates to use a base template

---------

Co-authored-by: jeremystretch <jstretch@netboxlabs.com>
jeremystretch added a commit that referenced this issue May 10, 2023
@jeremystretch
Changelog for #11670, #11900, #12131, #12233, #12286, #12323
2d0ac21
jsenecal pushed a commit to jsenecal/netbox that referenced this issue May 18, 2023
@abhi1693 @jeremystretch @jsenecal
Moves related ips to a tab (netbox-community#12502)
730caae 
* moves related ips to a tab netbox-community#12233

* Refactor IP address templates to use a base template

---------

Co-authored-by: jeremystretch <jstretch@netboxlabs.com>
jsenecal pushed a commit to jsenecal/netbox that referenced this issue May 18, 2023
@jeremystretch @jsenecal
Changelog for netbox-community#11670, netbox-community#11900, netbox-…
d4e8092 
…community#12131, netbox-community#12233, netbox-community#12286, netbox-community#12323
@jeremystretch jeremystretch mentioned this issue May 22, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abhi1693 abhi1693

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moves related ips to a tab netbox-community/netbox
5 participants
@jsenecal @abhi1693 @DanSheps @ThomasADavis @jeremystretch