Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect users away from /login, if they are already logged in #4977

Closed
n0emis opened this issue Aug 10, 2020 · 2 comments · Fixed by #5071
Closed

Redirect users away from /login, if they are already logged in #4977

n0emis opened this issue Aug 10, 2020 · 2 comments · Fixed by #5071
Assignees
@n0emis
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@n0emis
Copy link
Contributor

n0emis commented Aug 10, 2020

Environment

  • Python version: 3.8.5
  • NetBox version: 2.8.9

Proposed Functionality

When a already logged-in user access the /login url, they should be redirected to home or to the page from the parameter next.

I created a simple PoC: n0emis@061549b

Use Case

This would be especially usefull when using a Remote-Auth-Backend like django.contrib.auth.middleware.PersistentRemoteUserMiddleware, where the HTTP-Header only get's send when accessing the login-page.

Database Changes

No database-changes required

External Dependencies

No new external Dependencies required
@DanSheps DanSheps added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation type: feature Introduction of new functionality to the application labels Aug 11, 2020
@n0emis
Copy link
Contributor Author

n0emis commented Aug 21, 2020

@DanSheps Is this accepted so I can work on a PR?

@jeremystretch
Copy link
Member

@n0emis Yes, I'll assign this to you.

@DanSheps DanSheps added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Aug 25, 2020
@n0emis n0emis mentioned this issue Aug 29, 2020
Merged
jeremystretch added a commit that referenced this issue Sep 4, 2020
@jeremystretch
Changelog for #4977, #5095
dd01858
@jeremystretch jeremystretch mentioned this issue Sep 4, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@n0emis n0emis

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redirect users away from /login, if they are already logged in n0emis/netbox
3 participants
@DanSheps @jeremystretch @n0emis