Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable custom fields for organizational models #5370

Closed
jeremystretch opened this issue Nov 23, 2020 · 2 comments
Closed

Enable custom fields for organizational models #5370

jeremystretch opened this issue Nov 23, 2020 · 2 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone
v2.11

Comments

@jeremystretch
Copy link
Member

Environment

  • Python version: 3.6.9
  • NetBox version: 2.9.9

Proposed Functionality

Enable support for custom fields on organizational models (e.g. circuit types, rack roles, device roles, VLAN groups, etc.).

Use Case

Extension of NetBox's custom fields feature has long been demanded by users. Now that custom fields has been reimplemented in a sufficiently performant manner, we can revisit this.

Database Changes

Add a custom_field_data to each applicable model (via subclassing CustomFieldModel).

External Dependencies

None
@jeremystretch jeremystretch added type: feature Introduction of new functionality to the application API change status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Nov 23, 2020
@jeremystretch jeremystretch mentioned this issue Nov 23, 2020
Closed
@mngan
Copy link

mngan commented Dec 1, 2020

Can I add a vote for custom fields of Interfaces too?

@jeremystretch
Copy link
Member Author

jeremystretch commented Dec 1, 2020 •
edited
Loading

@mngan No, that is beyond the scope of this issue. (Edit: See #5401)

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Dec 21, 2020
@jeremystretch jeremystretch added this to the v2.11 milestone Dec 21, 2020
@jeremystretch jeremystretch self-assigned this Feb 25, 2021
jeremystretch added a commit that referenced this issue Feb 26, 2021
@jeremystretch
Closes #5370: Extend custom field support to organizational models
1dcd857
@jeremystretch jeremystretch mentioned this issue Apr 16, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v2.11
Development

No branches or pull requests
2 participants
@mngan @jeremystretch