Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device type compontent creation forms do not render #6714

Closed
jeremystretch opened this issue Jul 7, 2021 · 1 comment
Closed

Device type compontent creation forms do not render #6714

jeremystretch opened this issue Jul 7, 2021 · 1 comment
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@jeremystretch
Copy link
Member

NetBox version

v2.11.8

Python version

3.7

Steps to Reproduce

  1. Create a device type
  2. Attempt to add any type of component (e.g. interface) to a device type

Expected Behavior

The complete component creation form should render.

Observed Behavior

The page renders, however the form is empty.

This is due to a bug in the template which attempts to iterate through form.custom_fields. For device type components, custom_fields is not set. (The exception being raised is apparently swallowed within the template rendering, so our tests never caught it.)
@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation labels Jul 7, 2021
@jeremystretch jeremystretch self-assigned this Jul 7, 2021
@jeremystretch jeremystretch pinned this issue Jul 7, 2021
@jeremystretch jeremystretch mentioned this issue Jul 8, 2021
Merged
@jeremystretch jeremystretch unpinned this issue Jul 8, 2021
@candlerb candlerb mentioned this issue Jul 8, 2021
Closed
@mabroze
Copy link

mabroze commented Jul 8, 2021

Confirmed fixed in 2.11.9. Thanks for the quick resolution and your commitment to NetBox in general @jeremystretch @candlerb. Hope I'll be able to contribute in a meaningful way myself in the future.

candlerb pushed a commit to candlerb/netbox that referenced this issue Aug 4, 2021
@jeremystretch @candlerb
Fixes netbox-community#6714: Fix rendering of device type component c…
922da43 
…reation forms
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremystretch @mabroze