Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update social-core-auth dependency version #8486

Closed
oasys opened this issue Jan 28, 2022 · 3 comments
Closed

update social-core-auth dependency version #8486

oasys opened this issue Jan 28, 2022 · 3 comments
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@oasys
Copy link
Contributor

oasys commented Jan 28, 2022

NetBox version

v3.1.6

Feature type

Change to existing functionality

Proposed functionality

Bump social-auth-core dependency in requirements.txt to 4.2.0.

Use case

Use Okta SSO with Netbox. A regression in social_auth that prevented this from working is now fixed in python-social-auth/social-core#588 and included in version 4.2.0.

Database changes

none

External dependencies

Update requirements.txt:

-social-auth-core==4.1.0
+social-auth-core==4.2.0
@oasys oasys added the type: feature Introduction of new functionality to the application label Jan 28, 2022
@oasys
Copy link
Contributor Author

oasys commented Jan 28, 2022

For reference, here's the symptom I was seeing:

After successful authentication, netbox redirects to https://<okta custom url>/oauth2/.well-known/openid-configuration?client_id=xxxxxxx which is a 404. If I manually go to /.well-known/openid-configuration?client_id=xxxxxxxx (without the /oauth2/) in my browser, I see the correct json data.

If you want, assign to me, and I'll submit the (one-line) PR.

@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Jan 28, 2022
@jeremystretch
Copy link
Member

This will be bumped in the v3.1.6 release.

@davekempe
Copy link

@jeremystretch do you mean in 3.1.7?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

3 participants