Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default manufacturer on module insert #9417

Closed
shatt79 opened this issue May 24, 2022 · 4 comments · Fixed by #9563
Closed

Set default manufacturer on module insert #9417

shatt79 opened this issue May 24, 2022 · 4 comments · Fixed by #9563
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@shatt79
Copy link

shatt79 commented May 24, 2022

NetBox version

v3.2.3

Feature type

Change to existing functionality

Proposed functionality

When inserting a module into a device, the manufacturer of the module should default to the same manufacturer as the parent device. Eg, if I'm inserting a module into a Cisco ASR-9010, then the manufacturer of the module should be set to Cisco by default.

Use case

Saves time by not having to select the manufacturer of the module. The manufacturer of the module will almost always be the same as the manufacturer of the parent. The only exception being things like hard drive slots on servers and passive devices like modular distribution frames/patch panels. This is why the mfg field should only default to the parent's mfg and not be a read-only field.

Database changes

None

External dependencies

None

@shatt79 shatt79 added the type: feature Introduction of new functionality to the application label May 24, 2022
@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label May 24, 2022
@jeremystretch
Copy link
Member

This can be accomplished by pre-populating the device's manufacturer in the "add module" link: &manufacturer_id={{ object.device_type.manufacturer_id }} (something like that).

@shatt79
Copy link
Author

shatt79 commented May 24, 2022 via email

@jeremystretch
Copy link
Member

Sorry that was just a general note for anyone who would like to implement this. It's a change to be made in one (or more) of the HTML templates.

@huntabyte
Copy link
Contributor

I can implement this functionality.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jun 19, 2022
huntabyte added a commit to huntabyte/netbox that referenced this issue Jun 20, 2022
jeremystretch added a commit that referenced this issue Jun 20, 2022
Closes #9417: Pre-populate manufacturer when adding modules to devices
jeremystretch added a commit that referenced this issue Jun 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants