Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds description to elevation device tooltip #12488

Merged
merged 4 commits into from
May 5, 2023

Conversation

abhi1693
Copy link
Member

@abhi1693 abhi1693 commented May 4, 2023

Fixes: #11801

@kkthxbye-code
Copy link
Contributor

kkthxbye-code commented May 4, 2023

Currently it looks something like this:

image

With a 200 char description, it looks like this (with devtools, so might be wrong):

image

I find it a little busy, it's hard to distinguish where the description starts/ends.

Maybe we could use some newlines and labels?

image

It helps legibility imo, but I'm not really a great UX'er :)

@abhi1693
Copy link
Member Author

abhi1693 commented May 4, 2023

@kkthxbye-code I have implemented the way you have suggested.

@jeremystretch
Copy link
Member

jeremystretch commented May 5, 2023

I really like this, much cleaner! I went ahead and broke out the asset tag and serial to separate lines as well to improve readability.

Screenshot from 2023-05-05 08-55-43

@jeremystretch
Copy link
Member

Thanks @abhi1693!

@jeremystretch jeremystretch merged commit abdcfde into develop May 5, 2023
@abhi1693 abhi1693 deleted the feat/11801-tooltip-rack branch May 5, 2023 13:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip extension - Show the description in the rack for the device.
3 participants