CSV file import #6561
Merged
CSV file import #6561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Jun 8, 2021
|
|
||
| if form.is_valid(): | ||
| logger.debug("Form validation was successful") | ||
|
|
||
| try: | ||
| # Iterate through CSV data and bind each row to a new model form instance. | ||
| with transaction.atomic(): | ||
| headers, records = form.cleaned_data['csv'] | ||
| if request.FILES: |
There was a problem hiding this comment.
We should add a validation method to the form to check for both csv and upload_csv set, and raise a ValidationError if so as a sanity check.
There was a problem hiding this comment.
Added a method for this within the _import_form definition
|
@jeremystretch This would be useful to me, and it looks like all requested changes have been addressed. Could you give this another peek when you have a chance? |
|
Might need a bit of cleanup (e.g. stripping whitespace from uploaded files) but I can take care of that. Thanks! |
jeremystretch
approved these changes
Jul 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6560
An example / first draft of a solution for #6560 .
In the current implementation, if users try to use both the
CSVFileFieldand theCSVDataField, theCSVDataFieldwill be ignored and only the objects in the file will be imported. It should be unusual that both fields are populated, but let me know if you prefer to handle that case differently, such as by raising a validation error. The csv file is checked for errors (incorrect formatting, objects already exist, invalid columns) before importing.This solution involves some duplication between
CSVFileFieldandCSVDataField. If you prefer, I could remove most of the duplication by refactoring them to both inherit from a single class - say,CSVParsingField.