Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to merge a branch with non-existing custom fields #43

Closed
peteeckel opened this issue Aug 14, 2024 · 3 comments
Closed

Unable to merge a branch with non-existing custom fields #43

peteeckel opened this issue Aug 14, 2024 · 3 comments
Labels
type: bug Something isn't working

Comments

@peteeckel
Copy link

Plugin Version

0.3.0

NetBox Version

4.1-beta1

Python Version

3.11.5

Steps to Reproduce

Disclaimer: I have only tested with NetBox DNS so far.

  1. Create a branch
  2. Perform some arbitrary changes in NetBox DNS
  3. Try to merge the branch

Expected Behavior

The branch is merged

Observed Behavior

The branch status shows the following error message:

Screenshot 2024-08-14 at 11 38 14

When I look at the diffs, I see the following entry for the changes to the View object:

Screenshot 2024-08-14 at 11 46 24

The data shown under 'before' are all None, which is definitely not correct - the same is true for the other objects. The only exception is with deletes, where the before data correctly represents the status before the object was deleted.

@peteeckel peteeckel added the type: bug Something isn't working label Aug 14, 2024
@peteeckel
Copy link
Author

Additional information:

### Python 3.11.5 | Django 5.0.7 | NetBox NetBox Community v4.1.0-beta1
### lsmodels() will show available models. Use help(<model>) for more info.
>>> from netbox_dns.models import View
>>> for view in View.objects.all():
...     print(view.custom_fields)
... 
<RestrictedQuerySet []>
<RestrictedQuerySet []>
<RestrictedQuerySet []>
>>> for view in View.objects.all():
...     print(view.custom_field_data)
... 
{}
{}
{}

@jeremystretch
Copy link
Contributor

  1. Perform some arbitrary changes in NetBox DNS

Please detail specifically what change you're making, so that we can reproduce it exactly.

@peteeckel
Copy link
Author

OK, I failed to reproduce exactly this error with a fresh database, so I'll open another issue.

@jeremystretch jeremystretch closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants