Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve element name in error message for violations in DocView XMLs #21

Closed
kwin opened this issue Jul 28, 2022 · 1 comment · Fixed by #22
Closed

Improve element name in error message for violations in DocView XMLs #21

kwin opened this issue Jul 28, 2022 · 1 comment · Fixed by #22
Assignees
Milestone

Comments

@kwin
Copy link
Member

kwin commented Jul 28, 2022

Currently a violation in a DocView XML leads to the following message:

[WARNING] ValidationViolation: "netcentric-aem-classification: Element with name "{}test" inherits from resource '...' which is marked as 'granite:InternalArea (derived from parent content classification)'. It therefore violates the content classification!", filePath=... nodePath=.., line=5, column=82

The element name has currently the JCR Expanded Form which is not really common for XML. Therefore it should be emitted in a more human readable format.
Unfortunately the prefix used for the namespace URI is unknown to the validator, so it should just

  • emit the local name only in case the namespace is empty
  • emit the local name followed by the namespace URI in brackets in case the namespace is not empty
@kwin kwin self-assigned this Jul 28, 2022
@kwin kwin added this to the 1.1.0 milestone Jul 28, 2022
@kwin kwin closed this as completed in 593400c Jul 28, 2022
@kwin
Copy link
Member Author

kwin commented Jul 28, 2022

Unfortunately there was a bug in the fix, so I have to reopen.

@kwin kwin reopened this Jul 28, 2022
@kwin kwin modified the milestones: 1.1.0, 1.1.1 Jul 28, 2022
kwin added a commit that referenced this issue Jul 28, 2022
@kwin kwin closed this as completed in #22 Jul 29, 2022
kwin added a commit that referenced this issue Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant