Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that all values for whitelistedResourcePathPatterns start with "/" or a wildcard #7

Closed
kwin opened this issue Mar 12, 2020 · 0 comments · Fixed by #9
Closed

Make sure that all values for whitelistedResourcePathPatterns start with "/" or a wildcard #7

kwin opened this issue Mar 12, 2020 · 0 comments · Fixed by #9
Assignees
@kwin
Milestone
1.0.1

Comments

@kwin
Copy link
Member

kwin commented Mar 12, 2020

If the pattern does not match for a path starting with / (e.g. when the prefix/libs is forgotten) in the option whitelistedResourcePathPatterns it will never match and does not lead to the desired whitelisting. In such a case at least a WARN should be emitted.
@kwin kwin self-assigned this Mar 12, 2020
kwin added a commit that referenced this issue Mar 12, 2020
@kwin
Detect properly the documented option 'whitelistedResourcePathPatterns'
348cf45 
(while still supporting the old option
'whitelistedResourcePathsPatterns')

Validate given path patterns

This fixes #7
This fixes #8
@kwin kwin mentioned this issue Mar 12, 2020
Merged
@kwin kwin added this to the 1.0.1 milestone Mar 12, 2020
@kwin kwin closed this as completed in #9 Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwin kwin

Labels
None yet
Projects
None yet
Milestone
1.0.1
1 participant
@kwin