Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Grouping issues in the Overview screen #25

Closed
cakrit opened this issue Dec 3, 2020 · 3 comments
Closed

[BUG] Grouping issues in the Overview screen #25

cakrit opened this issue Dec 3, 2020 · 3 comments
Labels

Comments

@cakrit
Copy link
Contributor

cakrit commented Dec 3, 2020

image

We have a few problems with the groupings shown above in the overview screen:

  • "group" should be renamed to "cgroups"

  • "cgroups" are missing the cgroup network interfaces. e.g. see the following container, it has a "net eth0"
    image

  • "prometheus" is NOT a group. For each endpoint that we collect data from (e.g. redis), we need a separate grouping.

@cakrit
Copy link
Contributor Author

cakrit commented Jan 12, 2021

@jacekkolasa please speak with Ilya about this, it should be easy to fix.

@jacekkolasa
Copy link

I have limited options on how to group prometheus collectors, because on composition step we loose the app information, so the only way I can group is by job.

This is how charts are named in node-view:

prometheus_prometheus-mongodb_mongodb-sharded-shard0-data-1_metrics_tcp_9216.promhttp_metric_handler_requests_total
prometheus_prometheus-mongodb_mongodb-sharded-shard0-data-1_metrics_tcp_9216.promhttp_metric_handler_requests_in_flight

And in overview:

prometheus.promhttp_metric_handler_requests_in_flight
prometheus.promhttp_metric_handler_requests_total

@cakrit is this intentional? I guess it is, but I want to confirm.

This is what we get when grouping by job, which i get from first part of the family, for example:
promhttp_metric > promhttp

image

Is this OK?

@cakrit
Copy link
Contributor Author

cakrit commented Feb 1, 2021

This grouping is good! I'm closing and expect to see it live soon.

@cakrit cakrit closed this as completed Feb 1, 2021
@jacekkolasa jacekkolasa removed their assignment Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants