Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload source files to sentry. #17615

Closed
vkalintiris opened this issue May 8, 2024 · 0 comments · Fixed by #17627
Closed

Upload source files to sentry. #17615

vkalintiris opened this issue May 8, 2024 · 0 comments · Fixed by #17627
Assignees
Labels
area/build Build system (autotools and cmake).

Comments

@vkalintiris
Copy link
Collaborator

Summary

We need to add the logic we had in the rules file:

ifeq ($(ENABLE_SENTRY),true)
RELEASE_PIPELINE ?= Unknown
VERSION ?= Unknown
BUILD_DESTINATION ?= Unknown
SENTRY_CONFIG := -DENABLE_SENTRY=On \
-DNETDATA_SENTRY_ENVIRONMENT=$(RELEASE_PIPELINE) \
-DNETDATA_SENTRY_RELEASE=$(VERSION) \
-DNETDATA_SENTRY_DIST=$(BUILD_DESTINATION) \
-DNETDATA_SENTRY_DSN=$(SENTRY_DSN)
else
SENTRY_CONFIG := -DENABLE_SENTRY=Off
endif

if [ "${ENABLE_SENTRY}" = "true" ] && [ "${UPLOAD_SENTRY}" = "true" ]; then \
sentry-cli debug-files upload -o netdata-inc -p netdata-agent --force-foreground --log-level=debug --wait --include-sources /usr/src/netdata/debian/netdata/usr/sbin/netdata; \
fi

I think this should be placed under:

cmake --build "${BUILD_DIR}" --parallel "$(nproc)"

The new command should be something like:

sentry-cli debug-files upload -o netdata-inc -p netdata-agent --force-foreground --log-level=debug --wait --include-sources build/netdata
@vkalintiris vkalintiris added the area/build Build system (autotools and cmake). label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build system (autotools and cmake).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants