Non-interactive install fails if required packages are already present

[derTuca]

Bug report summary

When trying to run kickstart.sh non-interactively I get the following output:

bunnyshell@ip-10-0-0-249:~$ bash <(curl -Ss https://my-netdata.io/kickstart.sh) --dont-wait --non-interactive
System            : Linux
Operating System  : GNU/Linux
Machine           : x86_64
BASH major version:
 --- Downloading script to detect required packages... ---
$'[\E[2m/tmp/netdata-kickstart-Hk8QS0\E(B\E[0m]$ \E[1m\E[33m' wget -O - https://raw.githubusercontent.com/netdata/netdata-demo-site/master/install-required-packages.sh $'\E(B\E[0m\\n' --2019-01-21 16:11:21--  https://raw.githubusercontent.com/netdata/netdata-demo-site/master/install-required-packages.sh
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 151.101.16.133
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|151.101.16.133|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 41978 (41K) [text/plain]
Saving to: 'STDOUT'

-                                                                100%[==========================================================================================================================================================>]  40.99K  --.-KB/s    in 0.02s

2019-01-21 16:11:21 (1.78 MB/s) - written to stdout [41978/41978]

 OK  wget -O - https://raw.githubusercontent.com/netdata/netdata-demo-site/master/install-required-packages.sh

 --- Running downloaded script to detect required packages... ---
$'[\E[2m/tmp/netdata-kickstart-Hk8QS0\E(B\E[0m]$ \E[1m\E[33m' sudo /bin/bash /tmp/netdata-kickstart-Hk8QS0/install-required-packages.sh --dont-wait --non-interactive netdata $'\E(B\E[0m\\n' sudo: unable to resolve host ip-10-0-0-249
Loading /etc/os-release ...

/etc/os-release information:
NAME            : Ubuntu
VERSION         : 16.04.5 LTS (Xenial Xerus)
ID              : ubuntu
ID_LIKE         : debian
VERSION_ID      : 16.04

We detected these:
Distribution    : ubuntu
Version         : 16.04
Codename        : 16.04.5 LTS (Xenial Xerus)
Package Manager : install_apt_get
Packages Tree   : debian
Detection Method: /etc/os-release
Default Python v: 2

 > Checking if package 'autoconf-archive' is installed...
 > Checking if package 'zlib1g-dev' is installed...
 > Checking if package 'uuid-dev' is installed...
 > Checking if package 'libmnl-dev' is installed...
 > Checking if package 'python-yaml' is installed...
 > Checking if package 'python-pymongo' is installed...

All required packages are already installed. Now proceed to the next step.

 OK  sudo /bin/bash /tmp/netdata-kickstart-Hk8QS0/install-required-packages.sh --dont-wait --non-interactive netdata

 WARNING  It failed to install all the required packages, but installation might still be possible.

 ABORTED  Stopping due to non-interactive mode. Fix the issue or retry installation in an interactive mode.

Trying to install it interactively brings up the following:

bunnyshell@ip-10-0-0-249:~$ bash <(curl -Ss https://my-netdata.io/kickstart.sh)
System            : Linux
Operating System  : GNU/Linux
Machine           : x86_64
BASH major version:
 --- Downloading script to detect required packages... ---
$'[\E[2m/tmp/netdata-kickstart-NIDn3F\E(B\E[0m]$ \E[1m\E[33m' wget -O - https://raw.githubusercontent.com/netdata/netdata-demo-site/master/install-required-packages.sh $'\E(B\E[0m\\n' --2019-01-21 16:08:42--  https://raw.githubusercontent.com/netdata/netdata-demo-site/master/install-required-packages.sh
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 151.101.60.133
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|151.101.60.133|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 41978 (41K) [text/plain]
Saving to: 'STDOUT'

-                                                                100%[==========================================================================================================================================================>]  40.99K  --.-KB/s    in 0.02s

2019-01-21 16:08:43 (2.06 MB/s) - written to stdout [41978/41978]

 OK  wget -O - https://raw.githubusercontent.com/netdata/netdata-demo-site/master/install-required-packages.sh

 --- Running downloaded script to detect required packages... ---
$'[\E[2m/tmp/netdata-kickstart-NIDn3F\E(B\E[0m]$ \E[1m\E[33m' sudo /bin/bash /tmp/netdata-kickstart-NIDn3F/install-required-packages.sh netdata $'\E(B\E[0m\\n' sudo: unable to resolve host ip-10-0-0-249
Loading /etc/os-release ...

/etc/os-release information:
NAME            : Ubuntu
VERSION         : 16.04.5 LTS (Xenial Xerus)
ID              : ubuntu
ID_LIKE         : debian
VERSION_ID      : 16.04

We detected these:
Distribution    : ubuntu
Version         : 16.04
Codename        : 16.04.5 LTS (Xenial Xerus)
Package Manager : install_apt_get
Packages Tree   : debian
Detection Method: /etc/os-release
Default Python v: 2

 > Checking if package 'autoconf-archive' is installed...
 > Checking if package 'zlib1g-dev' is installed...
 > Checking if package 'uuid-dev' is installed...
 > Checking if package 'libmnl-dev' is installed...
 > Checking if package 'python-yaml' is installed...
 > Checking if package 'python-pymongo' is installed...

All required packages are already installed. Now proceed to the next step.

 OK  sudo /bin/bash /tmp/netdata-kickstart-NIDn3F/install-required-packages.sh netdata

 WARNING  It failed to install all the required packages, but installation might still be possible.

Press ENTER to attempt netdata installation >

OS / Environment

Ubnutu 16.04

Netdata version (ouput of netdata -V)

N/A

Component Name

N/A

Steps To Reproduce

bash <(curl -Ss https://my-netdata.io/kickstart.sh) --dont-wait --non-interactive

Expected behavior

I would expect the script to handle this situation and continue installing netdata.

[cakrit]

Thanks for the report. Please verify that the fix in #5241 works for you too.

[derTuca]

Yep, it works. Thanks!