ssl_check memory leak

[ilyam8]

Bug report summary

ssl_check module has memory leak

looks like that is the problem:

memory leak in SSLSocket.getpeercert()

https://bugs.python.org/issue29738

^^ i use update_every 1 in my test

OS / Environment

debian9.6, Python 2.7.13 (default, Sep 26 2018, 18:42:22)

Netdata version (ouput of netdata -V)

netdata v1.12.2-40-g97699c5c

Component Name

collectors/python.d.plugin/sslcheck

Steps To Reproduce

• run ssl_check module
• wait
• profit memory leak

https://bugs.python.org/issue25569

import socket
import ssl
import sys


def main():
    ctx = ssl.create_default_context()
    s = socket.create_connection(('www.bing.com', 443))
    s = ctx.wrap_socket(s, server_hostname='www.bing.com')
    while True:
        s.getpeercert()

        sys.stderr.write('.')
        sys.stderr.flush()


if __name__ == '__main__':
    main()

Expected behavior

no memory leak

[ilyam8]

@p-thurner

[ilyam8]

python version will be removed, this module will be rewritten in go

[ghost]

oh. pity :/ will you take care of the rewrite in go? I'm not much fluent in golang.

[ilyam8]

yes 👍