Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ssl check module #5626

Merged
merged 3 commits into from Mar 13, 2019
Merged

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Mar 13, 2019

Summary

Fixes: #5624

memory leak in SSLSocket.getpeercert()

https://bugs.python.org/issue29738

Component Name

collectors/python.d.plugin/sslcheck

Additional Information

@ilyam8
Copy link
Member Author

ilyam8 commented Mar 13, 2019

alarm was not removed on purpose

@ilyam8
Copy link
Member Author

ilyam8 commented Mar 13, 2019

debian9.6, Python 2.7.13 (default, Sep 26 2018, 18:42:22)

import socket
import ssl
import sys
import gc



def main():
    v = 0
    ctx = ssl.create_default_context()
    s = socket.create_connection(('www.bing.com', 443))
    s = ctx.wrap_socket(s, server_hostname='www.bing.com')
    while True:
        v += 1
        s.getpeercert()
        if v%100==0:
            print('COLLECT')
            gc.collect()

        sys.stderr.write('.')
        sys.stderr.flush()


if __name__ == '__main__':
    main()

Screenshot_20190313_200734

@ilyam8 ilyam8 merged commit 6bc05c4 into netdata:master Mar 13, 2019
@netdatabot netdatabot added area/collectors Everything related to data collection area/docs area/external/python labels Mar 13, 2019
This was referenced Mar 14, 2019
ilyam8 added a commit that referenced this pull request Mar 15, 2019
##### Summary

rename

> health/health.d/sslcheck.conf → health/health.d/x509check.conf

**Why**

sslcheck module (#5365) was removed(#5626) because of memory leak bug (#5624).

The module was rewritten in go (#5631, netdata/go.d.plugin#166). New module name - `x509check`. 

This PR changes name of the alarm.
@ilyam8 ilyam8 deleted the remove_ssl_check_module branch March 18, 2019 08:20
jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
##### Summary

Fixes: netdata#5624

> memory leak in SSLSocket.getpeercert()

https://bugs.python.org/issue29738

##### Component Name
[collectors/python.d.plugin/sslcheck](https://github.com/netdata/netdata/tree/master/collectors/python.d.plugin/sslcheck)
##### Additional Information
jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
##### Summary

rename

> health/health.d/sslcheck.conf → health/health.d/x509check.conf

**Why**

sslcheck module (netdata#5365) was removed(netdata#5626) because of memory leak bug (netdata#5624).

The module was rewritten in go (netdata#5631, netdata/go.d.plugin#166). New module name - `x509check`. 

This PR changes name of the alarm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collectors Everything related to data collection area/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants