x509check alarm fix #5645
Merged
x509check alarm fix #5645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakrit
approved these changes
Mar 14, 2019
|
Hi, is there an issue referring to this change? |
|
@paulkatsoulakis you are right, i added missing info. |
jackyhuang85
pushed a commit
to jackyhuang85/netdata
that referenced
this pull request
Jan 1, 2020
##### Summary rename > health/health.d/sslcheck.conf → health/health.d/x509check.conf **Why** sslcheck module (netdata#5365) was removed(netdata#5626) because of memory leak bug (netdata#5624). The module was rewritten in go (netdata#5631, netdata/go.d.plugin#166). New module name - `x509check`. This PR changes name of the alarm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rename
Why
sslcheck module (#5365) was removed(#5626) because of memory leak bug (#5624).
The module was rewritten in go (#5631, netdata/go.d.plugin#166). New module name -
x509check.This PR changes name of the alarm.