automatic shellchecking on .sh.in scripts#5165
Merged
paulfantom merged 2 commits intonetdata:masterfrom Feb 12, 2019
paulfantom:automatic_shellchecker
Merged
automatic shellchecking on .sh.in scripts#5165paulfantom merged 2 commits intonetdata:masterfrom paulfantom:automatic_shellchecker
paulfantom merged 2 commits intonetdata:masterfrom
paulfantom:automatic_shellchecker
Conversation
paulfantom
added
area/ci
no changelog
This was referenced Jan 13, 2019
Merged
Merged
ktsaou
previously approved these changes
Jan 14, 2019
Contributor
|
If I understand this one correctly, we'll need to correct the linter warnings before merging this, otherwise the build will start failing. Correct? If so, we'll need to add those corrections to this PR. |
paulfantom
changed the title
Contributor
Author
|
This is still blocked by other PR which adds those corrections. |
Contributor
|
I thought it would make sense to put those corrections in this PR, so we see the results in travis as the corrections are done. |
paulfantom
changed the title
paulfantom
requested review from
Ferroin,
cakrit and
vlvkobal
as code owners
cakrit
approved these changes
Feb 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unfortunately codacy doesn't check for code quality in this file due to wrong file extension. This adds mechanism to do shell code linting in travis as a blocking mechanism.
Component Name
ci
Additional Information
Part of larger effort to cleanup bash scripts with file extension ending in
.sh.in.Blocked by:
#5162
#5163
#5164